Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax react requirement to v16.8-18 #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

opiation
Copy link

@opiation opiation commented May 5, 2023

This react-mathquill package only uses the following exports from the peer React package:

  • useEffect
  • useLayoutEffect
  • useRef
  • useState (only used in examples/, not implementation)

These exports are all available in React as of v16.8.0 when hooks were first introduced and they have behaved fairly consistently since then. This seems like sufficient reason to relax the version requirements for the react peer dependency.

An example use case that benefits from this widened support allows one to upgrade react from v16.8.0 to v18.2.0 without having to update this package at the same time, shrinking the surface area of change that needs to happen all at once.

This package only uses the following exports from the peer React
package:
- `useEffect`
- `useLayoutEffect`
- `useRef`
- `useState` (only used in `examples/`, not implementation)

These exports are all available in React as of v16.8.0 when hooks were
first introduced and they have behaved fairly consistently since then.
This seems like sufficient reason to relax the version requirements for
the `react` peer dependency.

An example use case that benefits from this widened support allows one
to upgrade `react` from v16.8.0 to v18.2.0 without having to update
this package at the same time, shrinnking the surface area of change
that needs to happen all at once.
@opiation
Copy link
Author

@viktorstrate, and chance of this being approved and merged? Or is there some reason why this is undesirable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant