Merge pull request #159 from vil02/migrate_to_sonarqube-scan-action

chore: migrate to `sonarqube-scan-action`
vil02 · Dec 5, 2024 · 0044b58 · 0044b58
2 parents 32da618 + 7b000d4
commit 0044b58
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/.github/workflows/third_party_checks.yml b/.github/workflows/third_party_checks.yml
@@ -35,18 +35,11 @@ jobs:
         run: |
           ./generate_coverage_data.sh
 
-      - name: Fix code coverage paths for SonarCloud
-        # yamllint disable rule:line-length
-        run: |
-          cp coverage.xml coverage_for_sonarcloud.xml
-          sed -i 's/\/home\/runner\/work\/puzzle_generator\/puzzle_generator/\/github\/workspace/g' coverage_for_sonarcloud.xml
-        # yamllint enable rule:line-length
-
       - name: SonarCloud Scan
         if: "! github.event.pull_request.head.repo.fork "
-        uses: SonarSource/sonarcloud-github-action@v4
+        uses: SonarSource/sonarqube-scan-action@v4
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_HOST_URL: ${{ vars.SONAR_HOST_URL }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 
       - name: Upload coverage report to Codecov

diff --git a/sonar-project.properties b/sonar-project.properties
@@ -3,5 +3,5 @@ sonar.organization=vil02
 
 sonar.exclusions=coverage_for_sonarcloud.xml
 sonar.coverage.exclusions=**/tests/**
-sonar.python.coverage.reportPaths=coverage_for_sonarcloud.xml
+sonar.python.coverage.reportPaths=coverage.xml
 sonar.python.version=3.10, 3.11