Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add in_decrypt_str argument to _run_puzzle #29

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

vil02
Copy link
Owner

@vil02 vil02 commented Jul 24, 2024

No description provided.

Copy link

sonarcloud bot commented Jul 24, 2024

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.16% (target: -1.00%) 66.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7411aba) 72 64 88.89%
Head commit (2408ba8) 71 (-1) 63 (-1) 88.73% (-0.16%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#29) 3 2 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.32%. Comparing base (7411aba) to head (2408ba8).

Files Patch % Lines
puzzle_generator/create_puzzle.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   87.50%   87.32%   -0.18%     
==========================================
  Files           4        4              
  Lines          72       71       -1     
  Branches       11       11              
==========================================
- Hits           63       62       -1     
  Misses          8        8              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 merged commit b48f01d into master Jul 24, 2024
12 checks passed
@vil02 vil02 deleted the simplify_imports_in_create_puzzle branch July 24, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants