Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove asserts from bytes_utils.int_to_bytes #72

Merged
merged 10 commits into from
Aug 18, 2024

Conversation

muddi900
Copy link
Contributor

@muddi900 muddi900 commented Aug 6, 2024

fixes #62

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (be0459c) to head (dac8348).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          242       246    +4     
  Branches        24        26    +2     
=========================================
+ Hits           242       246    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this issue. I have few remarks.

Copy link
Owner

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply these suggestions, add the missing tests and we are done.

@vil02 vil02 changed the title Raising exceptions insted of assert in int_to_bytes [issue #62] style: remove asserts from bytes_utils.int_to_bytes (#62) Aug 18, 2024
@vil02 vil02 changed the title style: remove asserts from bytes_utils.int_to_bytes (#62) style: remove asserts from bytes_utils.int_to_bytes Aug 18, 2024
Copy link
Owner

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muddi900 please write me an e-mail: [email protected].

@vil02 vil02 merged commit 99e7f7f into vil02:master Aug 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove asserts from bytes_utils.int_to_bytes
3 participants