-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: remove assert
s from bytes_utils.int_to_bytes
#72
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 242 246 +4
Branches 24 26 +2
=========================================
+ Hits 242 246 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this issue. I have few remarks.
Co-authored-by: Piotr Idzik <[email protected]>
Co-authored-by: Piotr Idzik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply these suggestions, add the missing tests and we are done.
int_to_bytes
[issue #62]assert
s from bytes_utils.int_to_bytes
(#62)
assert
s from bytes_utils.int_to_bytes
(#62)assert
s from bytes_utils.int_to_bytes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muddi900 please write me an e-mail: [email protected].
fixes #62