Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show passenger information messages on station and train pages #18

Merged
merged 25 commits into from
Sep 23, 2023

Conversation

viliket
Copy link
Owner

@viliket viliket commented Sep 10, 2023

No description provided.

@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for junaan ready!

Name Link
🔨 Latest commit 105460a
🔍 Latest deploy log https://app.netlify.com/sites/junaan/deploys/650e82a3e782ff00089f4359
😎 Deploy Preview https://deploy-preview-18--junaan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.21% 🎉

Comparison is base (ffc8e75) 99.02% compared to head (105460a) 99.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   99.02%   99.23%   +0.21%     
==========================================
  Files          29       31       +2     
  Lines         613      783     +170     
  Branches      167      228      +61     
==========================================
+ Hits          607      777     +170     
  Misses          6        6              
Files Changed Coverage Δ
src/hooks/usePassengerInformationMessages.ts 100.00% <100.00%> (ø)
src/utils/passengerInformationMessages.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 105460a
Status: ✅  Deploy successful!
Preview URL: https://d41e4d68.live-trains-finland.pages.dev
Branch Preview URL: https://passenger-information-messag.live-trains-finland.pages.dev

View logs

- refactor: Move logic from usePassengerInformationMessages to separate passengerInformationMessages.ts utils
- Implement logic to follow delivery rules stated on the passenger information messages
- Add tests for usePassengerInformationMessages hook and passengerInformationMessages utils
@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@viliket viliket merged commit b360de7 into main Sep 23, 2023
11 checks passed
@viliket viliket deleted the passenger-information-messages branch September 23, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant