Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make map style support localization #30

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

viliket
Copy link
Owner

@viliket viliket commented Nov 4, 2023

No description provided.

Copy link

netlify bot commented Nov 4, 2023

Deploy Preview for junaan ready!

Name Link
🔨 Latest commit 0d9d943
🔍 Latest deploy log https://app.netlify.com/sites/junaan/deploys/65478bd7ad6ec400086a3c6f
😎 Deploy Preview https://deploy-preview-30--junaan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dcbe5b) 99.25% compared to head (0d9d943) 99.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          32       32           
  Lines         809      809           
  Branches      235      235           
=======================================
  Hits          803      803           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Nov 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d9d943
Status: ✅  Deploy successful!
Preview URL: https://93c896c8.live-trains-finland.pages.dev
Branch Preview URL: https://map-localization.live-trains-finland.pages.dev

View logs

# Conflicts:
#	src/utils/map.ts
When changing mapStyle which occurs when switching locale, maplibre-gl occasionally throws errors related to missing layer referred to in beforeId props. Disabling styleDiffing seems to be a workaround.

See related issues:
* maplibre/maplibre-gl-js#2587
* visgl/react-map-gl#939
* visgl/react-map-gl#1812
Copy link

sonarcloud bot commented Nov 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant