Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove engines/node from package.json #89

Closed
wants to merge 1 commit into from
Closed

Remove engines/node from package.json #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ember-engines-router-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@
"peerDependencies": {
"ember-source": "^3.28.0 || ^4.0.0"
},
"engines": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing these lines? Is there any documentation that you can link here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@villander this was discussed in embroider-build/addon-blueprint#15 and latest v2 addon blueprint does not provide engines.node

Copy link
Owner

@villander villander Jan 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but we still need to support V1 addons @SergeAstapov, does that make sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@villander I don't get your concern.

This is addon is v2 addon, meaning it does not have any Node.js runtime.
v1 addons do require runtime hence any v1 should properly declare Node.js versions it supports.

"node": "16.* || 18.* || >= 20"
},
"publishConfig": {
"registry": "https://registry.npmjs.org"
},
Expand Down