Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup.config.mjs to workaround not working re-export #95

Closed

Conversation

SergeAstapov
Copy link
Contributor

Closes #67

I still haven't found root cause why this happens, but I'm confident it's an issue around ember-auto-import as it's responsible for bundling.

Will create reproduction repo and then create ticket in ember-auto-import.
But meanwhile, this can merged as temp solution to fix an existing issue.

@SergeAstapov
Copy link
Contributor Author

@villander this is dirty and hacky, but would make things work for consumers of this addon (who don't care about this minor tweak as long as things work for them)

@SergeAstapov SergeAstapov marked this pull request as draft March 29, 2024 01:22
@SergeAstapov
Copy link
Contributor Author

need bit more time to confirm this actually fixes the issue

@villander
Copy link
Owner

@SergeAstapov could you please provide a public reproduction when you get the chance?

@SergeAstapov SergeAstapov marked this pull request as ready for review April 2, 2024 03:43
@SergeAstapov
Copy link
Contributor Author

created embroider-build/ember-auto-import#619 as an issue and created minimal reproduction in https://github.com/SergeAstapov/v2-addons-as-deps-of-lazy-engines-repro/commits/main/

@villander do you think you could land this and release (as well as #93 and #94) as is while above discussed and addressed? This would close existing issue #67 and make lib usable with no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.4.0: Could not find module initializers/ember-engines-router-service
2 participants