зделяль #3
Open
зделяль #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilunov
reviewed
Mar 13, 2020
| case class FinishOrder(orderId: Int, customer: ActorRef[Customer.Eat.type]) extends Command | ||
| case class FinishOrder(orderId: Int, customer: ActorRef[Customer.Eat.type]) extends Command | ||
|
|
||
| val random: Random = new Random() |
There was a problem hiding this comment.
Опять какой-то глобальный рандом, который шерится между всеми шефами. Можно хотя бы в Behaviors.setup его инициализирвоать
| val random: Random = new Random() | ||
|
|
||
| def apply(waiter: ActorRef[Waiter.Command], chefConfig: ChefConfig, seed: Long): Behavior[Command] = { | ||
| random.setSeed(seed) |
There was a problem hiding this comment.
В итоге у рандома будет сид последнего созданного шефа
| customerConfig: CustomerConfig, | ||
| seed: Long | ||
| ): Behavior[Command] = { | ||
| val random: Random = new Random(seed) |
|
|
||
| def apply(): Behavior[Command] = ??? | ||
| // Based on the fact that there is only one waiter in the system. | ||
| // And also on the fact that I can't no more with all this refactoring ;_; |
| } | ||
|
|
||
| object ChefSpec { | ||
| val config: ChefConfig = ChefConfig(Boundaries(1, 2)) |
There was a problem hiding this comment.
иммутабельные вещи запихивать сюда нормально, но всякие инбоксы – нет, они очень мутабельные
There was a problem hiding this comment.
может показаться что в тестах можно говнокодить (и это правда), но конкретно здесь проблема в том, что тест-кейзы могут запускаться отдельно от других кейзов, и тогда будет проблема с консистентностью начального стейта
xxsdfgdsa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.