-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: VRT(e2eテスト)を追加 #294
base: main
Are you sure you want to change the base?
Add: VRT(e2eテスト)を追加 #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
どこかに結果の画像を出せると良さそうな
CI落ちてるのはなんでなんでしょ....? |
pnpm run build | ||
- name: Upload playwright report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zipでレポート上げられても見づらい気が。画像をコメントなりって可能なんでしょうか
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
どうなんでしょう?
そういうActionがあればいいんですが...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actions/github-script
で頑張るしかないか...このPRでやるのは厳しいですよね
であればGHAでテスト前にNoto Sans CJK?あたりを適当にapt installすれば良い気がしますね
|
@sevenc-nanashi こちらどうしましょう。目的としてはPRなりでビルド結果の差分が出ていることを検知できれば良いと思っているのですが... |
VRTまで行かなくても、画面に差分が発生していたら自動で変化をPRコメントする、が良い感じになる...んですかね? |
が理想ですね。方法としては、画面までいかずとも静的ファイルの差分でも良いのかなと思ったりもしています |
VRTを追加します。(写真は失敗例)