Add: VRT（e2eテスト）を追加 #294
Open
Add: VRT（e2eテスト）を追加 #294
+104
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI落ちてるのはなんでなんでしょ....? |
| pnpm run build | ||
| - name: Upload playwright report |
There was a problem hiding this comment.
zipでレポート上げられても見づらい気が。画像をコメントなりって可能なんでしょうか
There was a problem hiding this comment.
どうなんでしょう？
そういうActionがあればいいんですが...
There was a problem hiding this comment.
actions/github-script で頑張るしかないか...このPRでやるのは厳しいですよね
|
GitHub Actionsのブラウザに日本語フォントが入っていないせいでにほんごテキストを描画出来ず死亡、ですね |
|
であればGHAでテスト前にNoto Sans CJK?あたりを適当にapt installすれば良い気がしますね
|
|
@sevenc-nanashi こちらどうしましょう。目的としてはPRなりでビルド結果の差分が出ていることを検知できれば良いと思っているのですが... |
|
VRTまで行かなくても、画面に差分が発生していたら自動で変化をPRコメントする、が良い感じになる...んですかね？ |
|
が理想ですね。方法としては、画面までいかずとも静的ファイルの差分でも良いのかなと思ったりもしています |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VRTを追加します。（写真は失敗例）