feat: グラフのバーをクリックすることで走者のページへ遷移できるようにした #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticWagomU
commented
Feb 20, 2024
| if(data.labels === null || data.labels![item.index] === null) return; | ||
| const labelText = data.labels![item.index] + ''; | ||
|
|
||
| const matched = /^\d+\.\s+(\S+)/.exec(labelText); |
There was a problem hiding this comment.
この部分の正規表現を甘めにしているんですが、厳密にしたほうがいいですか？
There was a problem hiding this comment.
tick から取る方法しかないということですよね。であれば、今のままで問題ないと思います！
monaqa
approved these changes
Feb 20, 2024
|
Svelte の prettier が入ってないことに気づきましたが、それは別 PR で対応しましょう。こちらはマージします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0006-02-20.18.10.00.mov
動画に残し忘れましたが、10位の人をクリックしても遷移することを確認しています。