Skip to content

WIP: Test python with 2.7, 3.4 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

WIP: Test python with 2.7, 3.4 #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6fd4fa
test python with 2.7, 3.4
tyru Jul 20, 2019
fc9c331
fixup! test python with 2.7, 3.4
tyru Jul 20, 2019
9012094
fixup! fixup! test python with 2.7, 3.4
tyru Jul 20, 2019
ff8d4bb
fixup! fixup! fixup! test python with 2.7, 3.4
tyru Jul 20, 2019
4457c18
fixup! fixup! fixup! fixup! test python with 2.7, 3.4
tyru Jul 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,13 @@ jobs:
- MAKE_TARGET=test
- TEST_PROFILE=vim-profile-master.txt
- name: Installed Vim with checks
language: python
python:
- "2.7"
- "3.4"
env:
- VIM_VERSION=installed
- VIMLPARSER_PYTHON_LIST='python2.7 python3.4'
- MAKE_TARGET="clean_compiled check js/test py/test test/node_position/test_position.out"
- TEST_PROFILE=vim-profile-installed.txt

Expand All @@ -38,6 +43,7 @@ script:
- uname -a
- which -a vim
- vim --cmd version --cmd quit
- if [ "$VIM_VERSION" = 'installed' ]; then python --version; fi
- make --keep-going $MAKE_TARGET

after_success:
Expand Down
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ js/test: js/vimlparser.js
test/run_command.sh node js/vimlparser.js

py/test: py/vimlparser.py
test/run_command.sh python py/vimlparser.py
for python in $(VIMLPARSER_PYTHON_LIST); do \
test/run_command.sh $$python py/vimlparser.py; \
done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this only checks for syntax errors I assume?

We would get this also when using flake8 (i.e. the "checkpy" target, #122) - not sure if it would need to run flake8 both via py2 and py3 (usually using py3 only is fine).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumption was wrong - it actually runs tests, and it makes sense to have this then with py2 and py3 I guess.


test/node_position/test_position.out: test/node_position/test_position.vim test/node_position/test_position.ok
vim -Nu test/vimrc -S test/node_position/test_position.vim
Expand Down