Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal : Data.List.Byte as Byte-like data operator and converter #690

Merged
merged 11 commits into from
Sep 13, 2019

Conversation

tsuyoshicho
Copy link
Contributor

@tsuyoshicho tsuyoshicho commented Sep 11, 2019

Byte-like List (0-255 number list) convert from/to other type

(It need #675 then include commit. When merge timing, rebase it)


validate({data}) *Vital.Data.List.Byte.validate()*
Return bool value.
{data} is List, all data as |Number| and it is min 0/max 255,
Copy link
Member

@ujihisa ujihisa Sep 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{data} is List, all data as |Number| and it is min 0/max 255,
returns 1 the given {data} is a |List| with its all values are

Copy link
Member

@ujihisa ujihisa Sep 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh it doesn't support multiline fixes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2bdfb5a a6ad36d at master instead. These are trivial doc fixes and don't need to be checked by CIs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!!

@ujihisa ujihisa merged commit 3e1b9db into vim-jp:master Sep 13, 2019
@ujihisa ujihisa mentioned this pull request Sep 13, 2019
@ujihisa
Copy link
Member

ujihisa commented Sep 13, 2019

Great thx!

@tsuyoshicho tsuyoshicho deleted the proposal/datalistbyte branch September 14, 2019 07:05
@tsuyoshicho tsuyoshicho restored the proposal/datalistbyte branch November 14, 2019 08:40
@tsuyoshicho tsuyoshicho deleted the proposal/datalistbyte branch November 18, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants