Fix type of property-get with coalesce #11152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoonE
commented
Nov 9, 2024
Comment on lines
+34
to
+45
| if (isset($context->vars_in_scope['$this'])) { | ||
| InstancePropertyFetchAnalyzer::analyze( | ||
| $statements_analyzer, | ||
| $isset_var, | ||
| $context, | ||
| ); | ||
| } | ||
| if (!isset($context->vars_in_scope[$var_id])) { | ||
| $context->vars_in_scope[$var_id] = Type::getMixed(); | ||
| } |
There was a problem hiding this comment.
The return value of InstancePropertyFetchAnalyzer::analyze is discarded, not sure if/how it needs to be handled.
| @@ -30,7 +31,16 @@ public static function analyze( | |||
| $var_id = '$this->' . $isset_var->name->name; | |||
|
|
|||
| if (!isset($context->vars_in_scope[$var_id])) { | |||
| $context->vars_in_scope[$var_id] = Type::getMixed(); | |||
| if (isset($context->vars_in_scope['$this'])) { | |||
There was a problem hiding this comment.
This check is necessary to keep this test passing:
psalm/tests/TypeReconciliation/ScopeTest.php
Lines 165 to 174 in 3f52ded
This checks if this is inside an object context and dynamic property access is possible.
MoonE
force-pushed
the
fix-property-get-coalesce-type
branch
from
c0672fe to
ab26b95
Compare
MoonE
force-pushed
the
fix-property-get-coalesce-type
branch
from
ab26b95 to
a3ffc49
Compare
orklah
added
the
release:fix
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11151
If the property was not already known inside the IssetAnalyzer::analyze function, it was added as mixed to the context.
This adds a check for dynamic properties.