Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object properties lose type #11156

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Fix object properties lose type #11156

merged 2 commits into from
Feb 16, 2025

Conversation

MoonE
Copy link
Contributor

@MoonE MoonE commented Nov 12, 2024

Fixes #9767
Fixes #10380
Fixes #11041

@MoonE MoonE force-pushed the object-property-types branch from ceaf4d9 to b5b96c0 Compare November 12, 2024 00:30
@MoonE
Copy link
Contributor Author

MoonE commented Nov 12, 2024

Wondering if this should default to never instead of mixed...

Is there a difference between object and object{}? As in one is an object which could have any properties the other is an object without any properties.
What about object{p: int, ...} and object{p: int}? Seems like the ... part is ignored for objects.

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Feb 16, 2025
@orklah
Copy link
Collaborator

orklah commented Feb 16, 2025

Thanks!

@orklah orklah merged commit d180638 into vimeo:5.x Feb 16, 2025
50 of 51 checks passed
@orklah
Copy link
Collaborator

orklah commented Feb 16, 2025

I actually merged that if 5.x that won't have more releases. Could you propose this fix for 6.x?

@MoonE MoonE deleted the object-property-types branch February 16, 2025 19:14
@MoonE MoonE mentioned this pull request Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
2 participants