Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate callmap, add \Roundable parameter possibility to round PHP8.4 #11326

Closed
wants to merge 1 commit into from

Conversation

goossda
Copy link

@goossda goossda commented Feb 20, 2025

This PR is for adding Roundable to the round- function as a possible parameter.

I also had to change the gen_callmap.sh to generate a new callmap.
After generation, more files did change, the changes to the round-function did pick up.

array (
),
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should have added the new signature in here as well as in CallMap.php.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand, because the override delta has this signature?

    'round' =>
    array (
      'old' =>
      array (
        0 => 'float',
        'num' => 'float|int',
        'precision=' => 'int',
        'mode=' => 'int<0, max>',
      ),
      'new' =>
      array (
        0 => 'float',
        'num' => 'float|int',
        'precision=' => 'int',
        'mode=' => 'RoundingMode|int<0, max>',
      ),
    ),

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this seems correct

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think i need to commit something else right? :)
It should be all there, however Github doesn't really allow us to check it online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants