Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix address in dolphin/relay connection example #89

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix address in dolphin/relay connection example #89

merged 1 commit into from
Jul 27, 2023

Conversation

isaacna
Copy link
Contributor

@isaacna isaacna commented Jul 27, 2023 •
edited
Loading

Fixing an issue with the Dolphin and relay connection example script

For dolphin, it seems like 127.0.0.1 works as the address while localhost does not. This seems to be consistent with how project-clippi handles the address for dolphin as well. Tested connecting to Dolphin on Windows and Mac

vinceau
vinceau approved these changes Jul 27, 2023
View reviewed changes
Copy link
Owner

@vinceau vinceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thanks for fixing this!

@vinceau vinceau merged commit 1c69b83 into vinceau:master Jul 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinceau vinceau vinceau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaacna @vinceau