Small Chores (splinetool#4)

* chore: Add prettierrc * Get rid of unnecessary files * Fix types * Remove example/src folder * Update main path
viniciusgrando · Nov 26, 2021 · 8fbc6b0 · 8fbc6b0
1 parent 7001ae4
commit 8fbc6b0
Show file tree

Hide file tree

Showing 12 changed files with 23 additions and 19 deletions.
diff --git a/.prettierignore b/.prettierignore
@@ -0,0 +1,3 @@
+node_modules/
+dist/
+package.json
diff --git a/.prettierrc b/.prettierrc
@@ -0,0 +1,3 @@
+{
+	"singleQuote": true
+}
diff --git a/example/src/App.tsx → example/App.tsx b/example/src/App.tsx → example/App.tsx
@@ -1,6 +1,7 @@
 import { useRef, useState, useEffect } from 'react';
-import { Spline, SplineRef } from '@splinetool/react-spline';
-import { SPEObject, SplineEvent } from '@splinetool/runtime';
+import { Spline, SplineRef } from '..';
+// TODO import these from react-spline
+import type { SPEObject, SplineEvent } from '@splinetool/runtime';
 import anime from 'animejs';
 
 function App() {

diff --git a/example/src/index.css → example/index.css b/example/src/index.css → example/index.css
diff --git a/example/index.html b/example/index.html
@@ -7,6 +7,6 @@
   </head>
   <body>
     <div id="root"></div>
-    <script type="module" src="/src/main.tsx"></script>
+    <script type="module" src="/main.tsx"></script>
   </body>
 </html>
diff --git a/example/src/main.tsx → example/main.tsx b/example/src/main.tsx → example/main.tsx
diff --git a/example/src/vite-env.d.ts → example/vite-env.d.ts b/example/src/vite-env.d.ts → example/vite-env.d.ts
diff --git a/package.json b/package.json
@@ -4,7 +4,7 @@
   "files": [
     "dist"
   ],
-  "types": "./dist/index",
+  "types": "./dist/Spline.d.ts",
   "main": "./dist/react-spline.umd.js",
   "module": "./dist/react-spline.es.js",
   "exports": {

diff --git a/src/Spline.css b/src/Spline.css
diff --git a/src/Spline.tsx b/src/Spline.tsx
@@ -1,5 +1,4 @@
 import { Application } from '@splinetool/runtime';
-import './Spline.css';
 
 import {
   useEffect,
@@ -218,8 +217,15 @@ export const Spline = forwardRef<SplineRef, SplineProps>(
 
     return (
       <div
-        className={responsive ? 'spline-responsive' : ''}
-        style={{ display: `${isLoading ? 'none' : 'flex'}`, ...style }}
+        style={{
+          display: `${isLoading ? 'none' : 'flex'}`,
+          // TODO this is not working, pass this option to Application.ts instead
+          ...(responsive && {
+            width: '100% !important',
+            height: '100% !important',
+          }),
+          ...style,
+        }}
       >
         <canvas ref={canvasRef} id={id} />
       </div>

diff --git a/src/index.ts b/src/index.ts
diff --git a/vite.config.ts b/vite.config.ts
@@ -8,7 +8,7 @@ export default defineConfig({
   root: 'example',
   build: {
     lib: {
-      entry: path.resolve(__dirname, './src/index.ts'),
+      entry: path.resolve(__dirname, './src/Spline.tsx'),
       name: 'react-spline',
       fileName: (format) => `react-spline.${format}.js`,
     },
@@ -17,18 +17,14 @@ export default defineConfig({
       // into your library
       external: ['react', 'react-dom', '@splinetool/runtime'],
       output: {
+        // Override dist folder because root is in the example/ folder
+        dir: 'dist',
         // Provide global variables to use in the UMD build
         // for externalized deps
         globals: {
           react: 'React',
           '@splinetool/runtime': 'SPRuntime',
         },
-        dir: 'dist',
-        assetFileNames: (assetInfo) => {
-          if (assetInfo.name == 'style.css')
-            return 'Spline.css';
-          return assetInfo.name;
-        },
       },
     },
   },