Skip to content

Commit

Permalink
Added laravel 5.7 support
Browse files Browse the repository at this point in the history
  • Loading branch information
@vinkla
vinkla committed Aug 23, 2018
1 parent b950d88 commit a453f78
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# CHANGELOG

## 5.1.0 (released 2018-08-23)

- Added laravel 5.7 support
- Removed laravel 5.6 support

## 5.0.0 (released 2018-03-12)

- Added Hashids 3.0 support
Expand Down
6 changes: 3 additions & 3 deletions composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"php": "^7.1.3",
"graham-campbell/manager": "^4.0",
"hashids/hashids": "^3.0",
"illuminate/contracts": "5.6.*",
"illuminate/support": "5.6.*"
"illuminate/contracts": "5.7.*",
"illuminate/support": "5.7.*"

This comment has been minimized.

Sign in to view

Copy link
@KABBOUCHI

KABBOUCHI Aug 27, 2018

Hello, Why you dropped support for 5.6? you can use "~5.6.0|~5.7.0"

This comment has been minimized.

Sign in to view

Copy link
@vinkla

vinkla Aug 27, 2018 •
edited
Loading

Author Owner

I don't want to maintain support for older versions of Laravel. If you want 5.6 support you can still install the previous version (5.0) of this package. This update wont affect any users of the package.

This comment has been minimized.

Sign in to view

Copy link
@jonbnewman

jonbnewman Sep 22, 2018 •
edited
Loading

I don't understand why you have to be so strict if nothing technically requires this limitation. I can understand not wanting to support older versions and in that case, just upgrade the required version as necessary.

I feel like this is creating unnecessary issues just for the sake of specificity when none is required. Doing this can cause problems when upgrading because of version mismatches/etc with what other packages require...that is why its best when packages allow the versioning to be flexible to the extent that they can/require specific versions.

My $0.02
},
"require-dev": {
"graham-campbell/analyzer": "^2.0",
Expand All @@ -38,7 +38,7 @@
},
"extra": {
"branch-alias": {
"dev-master": "5.0-dev"
"dev-master": "5.1-dev"
},
"laravel": {
"providers": [
Expand Down

0 comments on commit a453f78

Please sign in to comment.