Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shopify fork instead of original memcached #14

Closed
wants to merge 43 commits into from

Commits on Apr 1, 2016

  1. Fix warning: instance variable @no_backtrace not initialized

    - memcached/lib/memcached/exceptions.rb:52: warning: instance variable @no_backtrace not initialized
    - memcached/lib/memcached/exceptions.rb:61: warning: instance variable @no_backtrace not initialized
    hirocaster committed Apr 1, 2016
    Configuration menu
    Copy the full SHA
    db975bc View commit details
    Browse the repository at this point in the history
  2. Fix warning: assigned but unused variable - flags

    - memcached/lib/memcached/experimental.rb:25: warning: assigned but unused variable - flags
    hirocaster committed Apr 1, 2016
    Configuration menu
    Copy the full SHA
    ffcf16d View commit details
    Browse the repository at this point in the history
  3. Fix warning: assigned but unused variable

    - test/unit/memcached_experimental_test.rb:92: warning: assigned but unused variable - result
    - test/unit/memcached_experimental_test.rb:122: warning: assigned but unused variable - result
    - test/unit/memcached_experimental_test.rb:176: warning: assigned but unused variable - result
    - test/unit/memcached_experimental_test.rb:196: warning: assigned but unused variable - result
    - test/unit/memcached_experimental_test.rb:194: warning: assigned but unused variable - value
    - test/unit/memcached_test.rb:277: warning: assigned but unused variable - result
    - test/unit/memcached_test.rb:295: warning: assigned but unused variable - result
    - test/unit/memcached_test.rb:302: warning: assigned but unused variable - result
    - test/unit/memcached_test.rb:309: warning: assigned but unused variable - result
    - test/unit/memcached_test.rb:321: warning: assigned but unused variable - result
    - test/unit/memcached_test.rb:328: warning: assigned but unused variable - result
    - test/unit/memcached_test.rb:339: warning: assigned but unused variable - result
    - test/unit/memcached_test.rb:949: warning: assigned but unused variable - response
    - test/unit/memcached_test.rb:963: warning: assigned but unused variable - response
    hirocaster committed Apr 1, 2016
    Configuration menu
    Copy the full SHA
    881743d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    80be9f8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    28edb1d View commit details
    Browse the repository at this point in the history
  6. Fix warning: shadowing outer local variable

    - memcached/lib/memcached/memcached.rb:637: warning: shadowing outer local variable - server
    - memcached/lib/memcached/memcached.rb:700: warning: shadowing outer local variable - key
    hirocaster committed Apr 1, 2016
    Configuration menu
    Copy the full SHA
    9629305 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Configuration menu
    Copy the full SHA
    b72f5bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0aecf7c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dd1671f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3df868a View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Fix missing require for socket standard library

    Backport of commit from arthurnn#185
    dylanahsmith committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    cefc16d View commit details
    Browse the repository at this point in the history
  2. CI: Migrate to Github Actions

    Backport of arthurnn#186
    dylanahsmith committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    daca477 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    97cae52 View commit details
    Browse the repository at this point in the history
  4. Merge pull request arthurnn#192 from dylanahsmith/1-0-stable-github-a…

    …ctions
    
    Fix tests and migrate to Github Actions
    dylanahsmith authored Apr 7, 2021
    Configuration menu
    Copy the full SHA
    c07f7e0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    aa5e492 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7982fa4 View commit details
    Browse the repository at this point in the history
  7. Fix a method redefined warnings by removing the replaced method

    The warning was
    
    .../lib/memcached/memcached.rb:653: warning: method redefined; discarding old set_credentials
    .../lib/memcached/auth.rb:8: warning: previous definition of set_credentials was here
    
    Also, define all the methods for this class together in the same file,
    since auth.rb is always required anyways.
    dylanahsmith committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    75a51d1 View commit details
    Browse the repository at this point in the history
  8. Fix a circular require warning by autoloading optional modules

    The warnings was
    
    .../lib/memcached/rails.rb:1: warning: .../lib/memcached/rails.rb:1: warning: loading in progress, circular require considered harmful - .../lib/memcached.rb
    dylanahsmith committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    f06a3cb View commit details
    Browse the repository at this point in the history
  9. Fix an instance variable not initialized warning

    The warning was
    
    test/unit/rails_test.rb:91: warning: instance variable @called not initialized
    dylanahsmith committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    4fcdc5e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e539074 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Use rb_external_str_new_with_enc to reduce coupling to RString struct (

    …arthurnn#199)
    
    Avoids a "RSTRING_PTR is returning NULL!!" warning on ruby 3
    dylanahsmith authored Apr 13, 2021
    Configuration menu
    Copy the full SHA
    68b89fa View commit details
    Browse the repository at this point in the history
  2. Remove support for JRuby 1.6's C extensions

    This was an experimental feature that was disabled in JRuby 1.7 and
    then removed.
    dylanahsmith committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    0f50dae View commit details
    Browse the repository at this point in the history
  3. Remove conditional compilation that isn't needed anymore

    We are no longer using OBJSETUP to create a ruby string and rubinius
    has rb_external_str_new_with_enc, so we can just unconditionally use
    that function now.
    dylanahsmith committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    5c7a8ba View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    73a67c3 View commit details
    Browse the repository at this point in the history
  5. Merge pull request arthurnn#200 from arthurnn/use-newer-swig

    Regenerate the Swig bindings using Swig 4
    dylanahsmith authored Apr 13, 2021
    Configuration menu
    Copy the full SHA
    4ab53a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Remove broken ClientError retry logic that effectively did nothing (a…

    …rthurnn#198)
    
    Since the `!tries` check was never true (0 is truthy in ruby).
    dylanahsmith authored Apr 14, 2021
    Configuration menu
    Copy the full SHA
    5f1385a View commit details
    Browse the repository at this point in the history
  2. Remove experimental get_len method

    The tests for this method were getting skipped because the server
    doesn't actually support this command.  I'm not sure when it was
    supported. Support for this was already removed from libmemcached.
    Since it was experimental in this library, we may as well just remove
    it now.
    dylanahsmith committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    0a1bccc View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Deprecate Rlibmemcached and Memcached#get_from_last

    Since the libmemcached upgrade is a breaking change, so we can't keep
    the Rlibmemcached interface stable and memcached_get_from_last won't
    be available.
    dylanahsmith committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    b4783f9 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Merge pull request arthurnn#201 from arthurnn/1-0-stable-deprecations

    Add deprecations and remove an experimental method
    dylanahsmith authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    c2f5d8b View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Configuration menu
    Copy the full SHA
    c7514e4 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Fix memory leak from use of rb_external_str_new_with_enc

    I thought rb_external_str_new_with_enc did what I wanted, which was to
    pass ownership of the C string allocation and have ruby free it when it
    was done with it.  However, it actually just copies the string contents
    like with rb_str_new.
    dylanahsmith committed May 13, 2021
    Configuration menu
    Copy the full SHA
    5944e82 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e2fcf7c View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Merge pull request arthurnn#202 from arthurnn/1-x-clean-vendor-before…

    …-touch
    
    Clean vendor files before touching all of them to avoid missing changes
    casperisfine authored May 14, 2021
    Configuration menu
    Copy the full SHA
    ba89a97 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    411ad06 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Merge pull request arthurnn#203 from arthurnn/1-0-stable-fix-leak

    Fix unreleased memory leak from use of rb_external_str_new_with_enc
    casperisfine authored May 17, 2021
    Configuration menu
    Copy the full SHA
    e15fd2e View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. Merge pull request arthurnn#204 from Shopify/backport-interupt-handling

    Patch libmemcached to handle EINTR in poll(2)
    casperisfine authored May 26, 2021
    Configuration menu
    Copy the full SHA
    34090ff View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Fix compilation errors

    Specifically the problem is that when libmemcached is compiled, it can't
    find libsasl.  Libsasl exists, but the function it's checking for on
    macOS has been deprecated and that causes a compiler error.  Since
    libmemcached is compiled without sasl support that makes the Ruby
    extension blow up.
    tenderlove authored and byroot committed May 28, 2021
    Configuration menu
    Copy the full SHA
    6222c5d View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Configuration menu
    Copy the full SHA
    09e7761 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Configuration menu
    Copy the full SHA
    241c040 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Configuration menu
    Copy the full SHA
    b1372bf View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Fix show_backtraces: false leaking Exception#cause

    This code was likely fine back when it was written against Ruby 1.9.3,
    but since then `Kernel#raise` now automatically attach the currently rescued error
    as the new exception `cause`.
    
    Since this code was re-raising the same instance over and once a `cause` was
    attached it would never be de-associated, which in some contrived scenario could
    leak to information leak across requests / test etc.
    
    I ran a benchmark and the fastest way to raise exception I could find is:
    
    ```ruby
    raise ErrorClass, "message".freeze, EMPTY_ARRAY, cause: nil
    ```
    byroot committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    a553ff0 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Add gem release workflow

    tomasv committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    8796091 View commit details
    Browse the repository at this point in the history
  2. Add version rake task

    tomasv committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    fe62055 View commit details
    Browse the repository at this point in the history