-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shopify fork instead of original memcached #14
Commits on Apr 1, 2016
-
Fix warning: instance variable @no_backtrace not initialized
- memcached/lib/memcached/exceptions.rb:52: warning: instance variable @no_backtrace not initialized - memcached/lib/memcached/exceptions.rb:61: warning: instance variable @no_backtrace not initialized
Configuration menu - View commit details
-
Copy full SHA for db975bc - Browse repository at this point
Copy the full SHA db975bcView commit details -
Fix warning: assigned but unused variable - flags
- memcached/lib/memcached/experimental.rb:25: warning: assigned but unused variable - flags
Configuration menu - View commit details
-
Copy full SHA for ffcf16d - Browse repository at this point
Copy the full SHA ffcf16dView commit details -
Fix warning: assigned but unused variable
- test/unit/memcached_experimental_test.rb:92: warning: assigned but unused variable - result - test/unit/memcached_experimental_test.rb:122: warning: assigned but unused variable - result - test/unit/memcached_experimental_test.rb:176: warning: assigned but unused variable - result - test/unit/memcached_experimental_test.rb:196: warning: assigned but unused variable - result - test/unit/memcached_experimental_test.rb:194: warning: assigned but unused variable - value - test/unit/memcached_test.rb:277: warning: assigned but unused variable - result - test/unit/memcached_test.rb:295: warning: assigned but unused variable - result - test/unit/memcached_test.rb:302: warning: assigned but unused variable - result - test/unit/memcached_test.rb:309: warning: assigned but unused variable - result - test/unit/memcached_test.rb:321: warning: assigned but unused variable - result - test/unit/memcached_test.rb:328: warning: assigned but unused variable - result - test/unit/memcached_test.rb:339: warning: assigned but unused variable - result - test/unit/memcached_test.rb:949: warning: assigned but unused variable - response - test/unit/memcached_test.rb:963: warning: assigned but unused variable - response
Configuration menu - View commit details
-
Copy full SHA for 881743d - Browse repository at this point
Copy the full SHA 881743dView commit details -
Fix warning: ambiguous first argument; put parentheses or a space eve…
…n after `/' operator
Configuration menu - View commit details
-
Copy full SHA for 80be9f8 - Browse repository at this point
Copy the full SHA 80be9f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28edb1d - Browse repository at this point
Copy the full SHA 28edb1dView commit details -
Fix warning: shadowing outer local variable
- memcached/lib/memcached/memcached.rb:637: warning: shadowing outer local variable - server - memcached/lib/memcached/memcached.rb:700: warning: shadowing outer local variable - key
Configuration menu - View commit details
-
Copy full SHA for 9629305 - Browse repository at this point
Copy the full SHA 9629305View commit details
Commits on Apr 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b72f5bd - Browse repository at this point
Copy the full SHA b72f5bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aecf7c - Browse repository at this point
Copy the full SHA 0aecf7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd1671f - Browse repository at this point
Copy the full SHA dd1671fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3df868a - Browse repository at this point
Copy the full SHA 3df868aView commit details
Commits on Apr 7, 2021
-
Fix missing require for socket standard library
Backport of commit from arthurnn#185
Configuration menu - View commit details
-
Copy full SHA for cefc16d - Browse repository at this point
Copy the full SHA cefc16dView commit details -
Configuration menu - View commit details
-
Copy full SHA for daca477 - Browse repository at this point
Copy the full SHA daca477View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97cae52 - Browse repository at this point
Copy the full SHA 97cae52View commit details -
Merge pull request arthurnn#192 from dylanahsmith/1-0-stable-github-a…
…ctions Fix tests and migrate to Github Actions
Configuration menu - View commit details
-
Copy full SHA for c07f7e0 - Browse repository at this point
Copy the full SHA c07f7e0View commit details -
Merge pull request arthurnn#167 from hirocaster/fix-warnings
Fix warnings
Configuration menu - View commit details
-
Copy full SHA for aa5e492 - Browse repository at this point
Copy the full SHA aa5e492View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7982fa4 - Browse repository at this point
Copy the full SHA 7982fa4View commit details -
Fix a method redefined warnings by removing the replaced method
The warning was .../lib/memcached/memcached.rb:653: warning: method redefined; discarding old set_credentials .../lib/memcached/auth.rb:8: warning: previous definition of set_credentials was here Also, define all the methods for this class together in the same file, since auth.rb is always required anyways.
Configuration menu - View commit details
-
Copy full SHA for 75a51d1 - Browse repository at this point
Copy the full SHA 75a51d1View commit details -
Fix a circular require warning by autoloading optional modules
The warnings was .../lib/memcached/rails.rb:1: warning: .../lib/memcached/rails.rb:1: warning: loading in progress, circular require considered harmful - .../lib/memcached.rb
Configuration menu - View commit details
-
Copy full SHA for f06a3cb - Browse repository at this point
Copy the full SHA f06a3cbView commit details -
Fix an instance variable not initialized warning
The warning was test/unit/rails_test.rb:91: warning: instance variable @called not initialized
Configuration menu - View commit details
-
Copy full SHA for 4fcdc5e - Browse repository at this point
Copy the full SHA 4fcdc5eView commit details -
Merge pull request arthurnn#194 from dylanahsmith/fix-remaining-warnings
Fix remaining warnings
Configuration menu - View commit details
-
Copy full SHA for e539074 - Browse repository at this point
Copy the full SHA e539074View commit details
Commits on Apr 13, 2021
-
Use rb_external_str_new_with_enc to reduce coupling to RString struct (…
…arthurnn#199) Avoids a "RSTRING_PTR is returning NULL!!" warning on ruby 3
Configuration menu - View commit details
-
Copy full SHA for 68b89fa - Browse repository at this point
Copy the full SHA 68b89faView commit details -
Remove support for JRuby 1.6's C extensions
This was an experimental feature that was disabled in JRuby 1.7 and then removed.
Configuration menu - View commit details
-
Copy full SHA for 0f50dae - Browse repository at this point
Copy the full SHA 0f50daeView commit details -
Remove conditional compilation that isn't needed anymore
We are no longer using OBJSETUP to create a ruby string and rubinius has rb_external_str_new_with_enc, so we can just unconditionally use that function now.
Configuration menu - View commit details
-
Copy full SHA for 5c7a8ba - Browse repository at this point
Copy the full SHA 5c7a8baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73a67c3 - Browse repository at this point
Copy the full SHA 73a67c3View commit details -
Merge pull request arthurnn#200 from arthurnn/use-newer-swig
Regenerate the Swig bindings using Swig 4
Configuration menu - View commit details
-
Copy full SHA for 4ab53a5 - Browse repository at this point
Copy the full SHA 4ab53a5View commit details
Commits on Apr 14, 2021
-
Remove broken ClientError retry logic that effectively did nothing (a…
…rthurnn#198) Since the `!tries` check was never true (0 is truthy in ruby).
Configuration menu - View commit details
-
Copy full SHA for 5f1385a - Browse repository at this point
Copy the full SHA 5f1385aView commit details -
Remove experimental get_len method
The tests for this method were getting skipped because the server doesn't actually support this command. I'm not sure when it was supported. Support for this was already removed from libmemcached. Since it was experimental in this library, we may as well just remove it now.
Configuration menu - View commit details
-
Copy full SHA for 0a1bccc - Browse repository at this point
Copy the full SHA 0a1bcccView commit details
Commits on Apr 15, 2021
-
Deprecate Rlibmemcached and Memcached#get_from_last
Since the libmemcached upgrade is a breaking change, so we can't keep the Rlibmemcached interface stable and memcached_get_from_last won't be available.
Configuration menu - View commit details
-
Copy full SHA for b4783f9 - Browse repository at this point
Copy the full SHA b4783f9View commit details
Commits on Apr 20, 2021
-
Merge pull request arthurnn#201 from arthurnn/1-0-stable-deprecations
Add deprecations and remove an experimental method
Configuration menu - View commit details
-
Copy full SHA for c2f5d8b - Browse repository at this point
Copy the full SHA c2f5d8bView commit details
Commits on May 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c7514e4 - Browse repository at this point
Copy the full SHA c7514e4View commit details
Commits on May 13, 2021
-
Fix memory leak from use of rb_external_str_new_with_enc
I thought rb_external_str_new_with_enc did what I wanted, which was to pass ownership of the C string allocation and have ruby free it when it was done with it. However, it actually just copies the string contents like with rb_str_new.
Configuration menu - View commit details
-
Copy full SHA for 5944e82 - Browse repository at this point
Copy the full SHA 5944e82View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2fcf7c - Browse repository at this point
Copy the full SHA e2fcf7cView commit details
Commits on May 14, 2021
-
Merge pull request arthurnn#202 from arthurnn/1-x-clean-vendor-before…
…-touch Clean vendor files before touching all of them to avoid missing changes
Configuration menu - View commit details
-
Copy full SHA for ba89a97 - Browse repository at this point
Copy the full SHA ba89a97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 411ad06 - Browse repository at this point
Copy the full SHA 411ad06View commit details
Commits on May 17, 2021
-
Merge pull request arthurnn#203 from arthurnn/1-0-stable-fix-leak
Fix unreleased memory leak from use of rb_external_str_new_with_enc
Configuration menu - View commit details
-
Copy full SHA for e15fd2e - Browse repository at this point
Copy the full SHA e15fd2eView commit details
Commits on May 26, 2021
-
Merge pull request arthurnn#204 from Shopify/backport-interupt-handling
Patch libmemcached to handle EINTR in poll(2)
Configuration menu - View commit details
-
Copy full SHA for 34090ff - Browse repository at this point
Copy the full SHA 34090ffView commit details
Commits on May 28, 2021
-
Specifically the problem is that when libmemcached is compiled, it can't find libsasl. Libsasl exists, but the function it's checking for on macOS has been deprecated and that causes a compiler error. Since libmemcached is compiled without sasl support that makes the Ruby extension blow up.
Configuration menu - View commit details
-
Copy full SHA for 6222c5d - Browse repository at this point
Copy the full SHA 6222c5dView commit details
Commits on Jun 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 09e7761 - Browse repository at this point
Copy the full SHA 09e7761View commit details
Commits on Jan 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 241c040 - Browse repository at this point
Copy the full SHA 241c040View commit details
Commits on Jan 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b1372bf - Browse repository at this point
Copy the full SHA b1372bfView commit details
Commits on Jan 24, 2022
-
Fix
show_backtraces: false
leakingException#cause
This code was likely fine back when it was written against Ruby 1.9.3, but since then `Kernel#raise` now automatically attach the currently rescued error as the new exception `cause`. Since this code was re-raising the same instance over and once a `cause` was attached it would never be de-associated, which in some contrived scenario could leak to information leak across requests / test etc. I ran a benchmark and the fastest way to raise exception I could find is: ```ruby raise ErrorClass, "message".freeze, EMPTY_ARRAY, cause: nil ```
Configuration menu - View commit details
-
Copy full SHA for a553ff0 - Browse repository at this point
Copy the full SHA a553ff0View commit details
Commits on Apr 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8796091 - Browse repository at this point
Copy the full SHA 8796091View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe62055 - Browse repository at this point
Copy the full SHA fe62055View commit details