-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functional tests for getmemoryinfo, getrpcinfo, uptime #340
Conversation
Test issues:
# Local test
# "Poe => python tests/run_tests.py --test-name floresta_cli_getmemoryinfo" the result was
{'id': '0', 'result': {'locked': {'chunks_free': 0, 'chunks_used': 0, 'free': 0, 'locked': 0, 'total': 0, 'used': 0}}}
# Github-Action test
# "Poe => python tests/run_tests.py --test-name floresta_cli_getmemoryinfo" the result was
{'locked': {'chunks_free': 0, 'chunks_used': 28, 'free': 1629712, 'locked': 29036544, 'total': 9101312, 'used': 7471600}}}
When executed (locally): assert result["logpath"] == os.path.normpath(
os.path.join(
GetRpcInfoTest.data_dir,
"regtest",
"output.log"
)
) The |
Oh, shoot! I think you found a bug! For the first one, those stats only works if you build for a gnu system (it's the same for core). Just check the target triple to see if it ends with |
Ok, i will fix the code to keep it
Tested on a mac, so it make sense now why the values are zero. I will re-do tests on linux. |
Checked and fixed. Only the |
Do you want to fix this too? I think you just need to remove the backslash from this line Floresta/florestad/src/florestad.rs Line 449 in ee49346
|
Will fix (i was trying to find it). |
* getmemoryinfo (linux only) * getrpcinfo * uptime fix: florestad getrpcinfo command and florestad binary on tests * florestad/src/florestad.rs: bug fix on start method when send 'logpath' from 'floresta-cli getrpcinfo' command; fix: check for florestad binaries * search for binaries in /tmp/floresta-integration-tests or ./target/release * tests/test_framework/test_framework: added full path of 'florestad' binary to avoid break tests
What is the purpose of this pull request?
Summary
Added functional tests for floresta-cli commands:
getmemoryinfo
getrpcinfo
uptime