Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build floresta-cli instead of floresta_cli #345

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: build floresta-cli instead of floresta_cli #345

merged 1 commit into from
Jan 22, 2025

Conversation

luisschwab
Copy link
Contributor

@luisschwab luisschwab commented Jan 22, 2025 •
edited
Loading

Throughout documentation, the CLI client is referred to as floresta-cli. However, floresta_cli is built instead.

This PR simply modifies floresta-cli/Cargo.toml to build floresta-cli instead and adjusts the Dockerfile.

@luisschwab luisschwab force-pushed the fix/dash-not-underscore branch from ae06e01 to 7c80df1 Compare January 22, 2025 17:25
@jaoleal
Copy link
Contributor

jaoleal commented Jan 22, 2025 •
edited
Loading

Oh nice! This is really annoying.

Did you checked all the other mentions of floresta_cli ?

@luisschwab
Copy link
Contributor Author

Did you checked all the other mentions of floresta_cli ?

Yes, grep -rn floresta_cli couldn't find anything else.

@Davidson-Souza
Copy link
Collaborator

ACK 7c80df1

@Davidson-Souza Davidson-Souza merged commit 97ecf8f into vinteumorg:master Jan 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisschwab @jaoleal @Davidson-Souza