code quality- Fixing serde clippy warning #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK 1a0a09a |
|
ACK 1a0a09a. NIT: can you sign the commit, please ? |
siddheshzz
force-pushed
the
code-quality-simplifying-serde
branch
from
1a0a09a to
f4232ba
Compare
Signed-off-by: Siddhesh Z <[email protected]>
siddheshzz
force-pushed
the
code-quality-simplifying-serde
branch
from
f4232ba to
8da34aa
Compare
|
re-ACK 8da34aa |
|
re-ACK 8da34aa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This PR fixed issue #361 part 2 fixing serde clippy warning.
Which crates are being modified?
Description
The purpose of PR is to fix clippy warning related to serde in slip132 and improving code quality along with applying fix to empty line.
Notes to the reviewers
As per recommendation the serde import can be simplified, and serde is always available so we can have a direct way by importing.
Simplifying serde in [slip132.rs]
Fix the clippy warning -
consider parenthesizing your expression: `0x40000002 | (1 << 24)`empty line after doc commentChecklist
just lintcargo test