Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code quality:Fix code simplification clippy warnings #371

Conversation

siddheshzz
Copy link
Contributor

What is the purpose of this pull request?

This PR is realted to #358 . Fixing and removing remaining code simplification clippy warnings.

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:Code Quality

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: .

Description

Fixing and removing remaing code simplification clippy warnings.
No clippy warning can be seen now

Created type aliase type PeerData = (HeaderList, BlockHashMap, BlockDataMap); for very complex type used warning.

Notes to the reviewers

Checklist

  • I've signed all my commits
  • I ran just lint
  • I ran cargo test
  • I've checked the integration tests
  • I've followed the contribution guidelines
  • I'm linking the issue being fixed by this PR (if any)

@Davidson-Souza
Copy link
Collaborator

@siddheshzz this is conflicting with master. Please do a rebase and squash your commits

@siddheshzz siddheshzz force-pushed the remove-code-simplification-clippy-warnings branch from d8fb25d to b32455b Compare February 12, 2025 06:46
@Davidson-Souza Davidson-Souza merged commit 121e3ea into vinteumorg:master Feb 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants