Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subproj split #36

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Subproj split #36

merged 5 commits into from
Feb 11, 2025

Conversation

Grillo-0
Copy link
Collaborator

@Grillo-0 Grillo-0 commented Feb 5, 2025

This is a big one, a lot of attention is needed to keep everything working

The TAP version string is not case insensitive, we currently print
"Version", but it should be "version".
@Grillo-0 Grillo-0 force-pushed the subproj-split branch 3 times, most recently from 34066a1 to d915874 Compare February 9, 2025 19:17
@artP2
Copy link
Contributor

artP2 commented Feb 10, 2025

Add instructions about vin2dot and also how to run the tests.

@Grillo-0 Grillo-0 force-pushed the subproj-split branch 2 times, most recently from c213be2 to 8198720 Compare February 10, 2025 23:47
@Grillo-0 Grillo-0 requested a review from artP2 February 10, 2025 23:47
The project is growing, now we have two projects (vinumc and vunit) in
the future we're going to have more. To organize this, turn this repo
into a monorepo[1], were all vinum related projects reside.

The Autools build system is not up to the task (the SUBDIRS situation
is really painful when doing something like this).

So, change the build system to meson[2], using it's subproject
feature[3] makes the whole thing really manageable. Also, not having a
bunch of build scripts scattered around the project is a positive.

[1]: https://en.m.wikipedia.org/wiki/Monorepo 
[2]: https://mesonbuild.com/
[3]: https://mesonbuild.com/Subprojects.html

Fixes: #25
Fixes: #34
Fixes: #34
Copy link
Contributor

@artP2 artP2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artP2 artP2 merged commit 66c304c into develop Feb 11, 2025
2 checks passed
@artP2 artP2 deleted the subproj-split branch February 11, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants