-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subproj split #36
Merged
Merged
Subproj split #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
731d770
to
7d2911f
Compare
This was
linked to
issues
Feb 5, 2025
Closed
artP2
reviewed
Feb 5, 2025
The TAP version string is not case insensitive, we currently print "Version", but it should be "version".
34066a1
to
d915874
Compare
artP2
reviewed
Feb 10, 2025
Add instructions about vin2dot and also how to run the tests. |
c213be2
to
8198720
Compare
The project is growing, now we have two projects (vinumc and vunit) in the future we're going to have more. To organize this, turn this repo into a monorepo[1], were all vinum related projects reside. The Autools build system is not up to the task (the SUBDIRS situation is really painful when doing something like this). So, change the build system to meson[2], using it's subproject feature[3] makes the whole thing really manageable. Also, not having a bunch of build scripts scattered around the project is a positive. [1]: https://en.m.wikipedia.org/wiki/Monorepo [2]: https://mesonbuild.com/ [3]: https://mesonbuild.com/Subprojects.html Fixes: #25 Fixes: #34 Fixes: #34
8198720
to
ab0f265
Compare
artP2
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one, a lot of attention is needed to keep everything working