Help flag #43
Merged
Help flag #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To simplify tests that involves file IO, it would be great to have a set o IO function that accept strings as an argument.
The fork return check has a wrong assert message, stating that a `pipe()` function error out.
Some tests may not want to deal with some of the IO strings. So make them optional.
We don't have a test that checks writing of output to a file, create a simple one.
We don't have a test that checks the output flag working, create a simple one.
It will be easier to parse more args if we split the parsing with the application of those arguments.
JeanJPNM
approved these changes
Mar 8, 2025
This argument for loop is not future proof, is better to use the libc getopt_long function for argument parsing. Also, is good to have a way to declare new flags in a centralized location, so abstract the getopt function with a `parse_cmdline` function that receives a list of `struct flag`.
Now that we have a list of available flags it's easy to create a help function. Fixes: #42
JeanJPNM
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.