Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add input device config interface #404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add input device config interface #404

wants to merge 1 commit into from

Conversation

lbwtw
Copy link

@lbwtw lbwtw commented Jul 10, 2024

Issue: #384

zccrs
zccrs requested changes Jul 11, 2024
View reviewed changes
src/server/kernel/winputdevice.h
@@ -51,6 +53,27 @@ class WInputDevice : public WWrapObject
void setSeat(WSeat *seat);
WSeat *seat() const;

libinput_device *libinput_device_handle();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libinputDeviceHandle

src/server/kernel/winputdevice.h
@@ -51,6 +53,27 @@ class WInputDevice : public WWrapObject
void setSeat(WSeat *seat);
WSeat *seat() const;

libinput_device *libinput_device_handle();

bool setSendEventsMode(uint32_t mode);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can enum?

src/server/kernel/winputdevice.cpp
@@ -109,4 +390,99 @@ QInputDevice *WInputDevice::qtDevice() const
return d->qtDevice;
}

libinput_device *WInputDevice::libinput_device_handle()
{
return QWLibinputBackend::getDeviceHandle(handle());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (QWLibinputBackend::isLibinputDevice)

src/server/kernel/winputdevice.cpp

bool WInputDevice::setSendEventsMode(uint32_t mode)
{
return configSendEventsMode(libinput_device_handle(), mode);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe libinput_device_handle() is nullptr

src/server/kernel/winputdevice.h
@@ -7,6 +7,8 @@
#include <QObject>
#include <qwglobal.h>

#include <libinput.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't include libinput.h in public header file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zccrs zccrs zccrs requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbwtw @zccrs @zzxyb