Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing several issues with malformed triggers #827

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

marcoeilers
Copy link
Contributor

Fixing viperproject/carbon#489 by:

  • marking equality expressions as not allowed in triggers
  • fixing the check for which quantified variables are contained in an expression for both trigger inference and trigger consistency checks, which was previously incorrect in the presence of let-expressions. In particular, let x == (y) in e was considered to contain variable y even if e does not contain any reference to x (or y itself).

@marcoeilers marcoeilers requested a review from JonasAlaif January 8, 2025 15:41
@marcoeilers marcoeilers merged commit 75fe55c into master Feb 3, 2025
5 checks passed
@marcoeilers marcoeilers deleted the meilers_let_trigger_fixes branch February 3, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant