Skip to content

Commit

Permalink
Fix false positive message to move SSL certificate to default location
Browse files Browse the repository at this point in the history
Note: This happens because `&get_website_ssl_file($d, "cert")` can also return a link to `ssl.combined` file. Checking only for private key must be more than enough.
  • Loading branch information
iliajie committed Jul 24, 2024
1 parent 7decdfd commit 75d8548
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions cert_form.cgi
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,8 @@ if (&domain_has_ssl_cert($d)) {

# Show button to copy to the default location
if (!$d->{'ssl_same'} &&
(&get_website_ssl_file($d, "cert") ne
&default_certificate_file($d, "cert")) ||
(&get_website_ssl_file($d, "key") ne
&default_certificate_file($d, "key"))) {
&get_website_ssl_file($d, "key") ne
&default_certificate_file($d, "key")) {
my $defcert_dir = &default_certificate_file($d, "cert");
$defcert_dir =~ s|/[^/]+$||;
print &ui_hr() if (!$ui_hr++);
Expand Down

0 comments on commit 75d8548

Please sign in to comment.