-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/209 add of initial class for cefx template and study template for default subsystems #221
base: development
Are you sure you want to change the base?
Conversation
Hi Dimitri,
didn’t we close this PR? I thought we decided that all features of this PR are also in this:
#209
Why do we have it here again?
Cheers
Tobi
Von: Dimitri Ngatcha Pokouane ***@***.***>
Gesendet: Donnerstag, 14. März 2024 10:55
An: virtualsatellite/VirtualSatellite4-CEF ***@***.***>
Cc: Franz, Tobias ***@***.***>; Review requested ***@***.***>
Betreff: Re: [virtualsatellite/VirtualSatellite4-CEF] Feature/209 add of initial class for cefx template and study template for default subsystems (PR #221)
@DimitriDiantos<https://github.com/DimitriDiantos> requested your review on: #221<#221> Feature/209 add of initial class for cefx template and study template for default subsystems.
—
Reply to this email directly, view it on GitHub<#221 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AL2YSL4K3MC55H3IFX5OK43YYFXYBAVCNFSM6AAAAABEVYJ5JOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGEYTKNJWGQ2TOMA>.
You are receiving this because your review was requested.Message ID: ***@***.******@***.***>>
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #221 +/- ##
==============================================
Coverage 88.00% 88.00%
Complexity 518 518
==============================================
Files 74 74
Lines 1750 1750
Branches 217 217
==============================================
Hits 1540 1540
Misses 134 134
Partials 76 76 |
Because i couldn't push the update on github. I got a message like the failed. You can see the picture attached. |
Hey Dima, |
Also, dont forget to update this branch, so it has the current changes of development |
Okay, the problem was that the CommandHelper is using the new discipline API. Furthermore the ElementDefinitions do not have PowerEquipment parameters. |
Thank you for the feedback. Initially, I used the target release platform and made the modifications accordingly. However, when I pushed to GitHub, an error occurred indicating that 'setUser' did not exist. Consequently, I had to switch to the target development platform. If you could verify this, you will see. |
|
Thanks for your comment. Initially, I used the target release platform and made the modifications accordingly. However, when I pushed to GitHub, an error occurred indicating that 'setUser' did not exist. Consequently, I had to switch to the target development platform. See the picture attached below. |
EC:Equipment in the CT. Also exchanging positions between PT and CT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looking good :)
…CEFX_template-and_study_template_for_default_subsystems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The looks good to me.
Following things I noticed:
- The Subsystem under the CT:System has PowerParameters. I think we agreed on only adding mass parameters by default. same with SystemPowerParameters.
- When adding a Subsystem or Equipment Power as well as TemperatureParameters are getting added. Should this be the default or only the mass parameters?
- An Equipment can be added on Subsystemlevel. But I guess this should be possible due to the dynamic structure of the Product Structure Concept? What do you think @franzTobiasDLR
Despite that I think it can be merged :)
…study_template_for_default_subsystems' of https://github.com/virtualsatellite/VirtualSatellite4-CEF.git into feature/209-add_of_initial_class_for_CEFX_template-and_study_template_for_default_subsystems
Okay Dennis :). i modified it. |
...efx.ui/src/de/dlr/sc/virsat/model/extension/cefx/ui/templates/DLRCEFXStudyCommandHelper.java
Outdated
Show resolved
Hide resolved
@dellerDLR can you check if we can merge this PR? |
To accomplish this task, we followed the steps outlined below:
Created the CEF X package.
Developed various classes in accordance with the principles of the CEF Template and implemented them.
Incorporated the different components of the template into the template Menu to ensure visibility.
Updated the "Create DLR CEFX Equipment" command.
Addressed and resolved any errors encountered during the process.
Default subsystems encompasses:
Power
Structure
AOCS
Payload
DataHandling.