Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BeIn #26

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Add support for BeIn #26

merged 3 commits into from
Jul 14, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 14, 2024

Pull Request (PR) description

  • Add support for Should operators:
    • BeIn

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md and source/WikiSource.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where applicable). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner July 14, 2024 13:09
@johlju johlju changed the title F/support be in Add support for BeIn Jul 14, 2024
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99%. Comparing base (8cba13b) to head (271c6d1).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main    #26   +/-   ##
===================================
  Coverage    99%    99%           
===================================
  Files        26     28    +2     
  Lines      1015   1088   +73     
===================================
+ Hits       1012   1085   +73     
  Misses        3      3           
Flag Coverage Δ
unit 99% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
source/Private/Convert-ShouldBeIn.ps1 100% <100%> (ø)
source/Private/Convert-ShouldNotThrow.ps1 100% <100%> (ø)
source/Private/Get-PesterCommandParameter.ps1 100% <100%> (ø)
source/Private/Get-PipelineBeforeShould.ps1 100% <ø> (ø)
source/Private/Test-IsPipelinePart.ps1 100% <100%> (ø)
source/Public/Convert-PesterSyntax.ps1 96% <100%> (+<1%) ⬆️

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 9ad45fc into viscalyx:main Jul 14, 2024
13 checks passed
@johlju johlju deleted the f/support-BeIn branch July 14, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support convert Should -BeIn to v6 syntax
1 participant