Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync changes #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

sync changes #2

wants to merge 2 commits into from

Conversation

helfaham
Copy link

@helfaham helfaham commented Feb 7, 2019

No description provided.

Copy link
Owner

@vischia vischia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I am taking the occasion for introducing you to the magic world of PR reviews 💃

You will hate me, but then when you will have to make a PR to code freaks (I mean to semi-professional software engineers) you will be already in control of good commit practices ;)

//std::vector<ttH::Lepton> selElectrons;
//std::vector<ttH::Lepton> selMuons;
//std::vector<ttH::Lepton> selleptons;

std::vector<ttH::Dilepton> ll;
std::vector<ttH::DileptonMet> llmet;
std::vector<ttH::Dijet> jj;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is usually desirable to not have whiteline removed/added without a specific reason.

I am usually personally quite indifferent to that, but there are very picky persons here and there :)

The general idea is that if you don't really need to remove/add a whiteline there, then there is no reason for having it.

@@ -13,10 +13,11 @@
#include <cp3_llbb/Framework/interface/HLTProducer.h>

#include <cmath>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, whiteline should be added back

#define ttH_GEN_DEBUG (false)
#define TT_GEN_DEBUG (false)


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason to add a whiteline here

@@ -37,7 +38,6 @@ void ttHAnalyzer::analyze(const edm::Event& event, const edm::EventSetup&, const
jj.clear();
//llmetjj.clear();
//llmetjj_cmva.clear();

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whiteline

@@ -339,9 +339,15 @@ void ttHAnalyzer::analyze(const edm::Event& event, const edm::EventSetup&, const
if (allelectrons.p4[ielectron].Pt() > m_subleadingElectronPtCut
&& fabs(allelectrons.p4[ielectron].Eta()) < m_electronEtaCut)
{

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whiteline

}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whiteline

int nElectrons=leptons.size();
//std::cout<<" # of ele: "<< nElectrons <<std::endl;
if(nElectrons!=1) return;

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two whitelines

}//end of loop on muons

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whiteline

@@ -30,7 +30,7 @@
enable = cms.bool(True),
categories_parameters = cms.PSet(
# Per-category lepton pt cuts
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't understand this commit. I don't remember I touched that intentionally :)

@@ -57,7 +57,14 @@
muonLooseIsoCut = cms.untracked.double(.25), # https://twiki.cern.ch/twiki/bin/view/CMS/TopMUO
muonTightIsoCut = cms.untracked.double(.15), # https://twiki.cern.ch/twiki/bin/view/CMS/TopMUO
muonEtaCut = cms.untracked.double(2.4),
electrons_loose_wp_name = cms.untracked.string("cutBasedElectronID-Summer16-80X-V1-loose"),
#electrons_loose_wp_name = cms.untracked.string("cutBasedElectronID-Summer16-80X-V1-loose"), #old working point

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whiteline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants