-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pydeck-carto): Use local isPureObject #8880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it fixes the problem...
Found the cause of the bug. In the pydeck environment we have only the imports coming from the jupyter-widget build, which pulls in dependencies here...
... and cherry-picks ... deck.gl/modules/core/src/scripting/loadersgl.ts Lines 1 to 5 in 950d666
... and does not include Likely there will be more options for dependency management if we are moving pydeck toward Anywidget, which has good support for ESM. |
38e3536
to
4d6433a
Compare
Such functions should probably be in |
Loading the latest version of pydeck-carto in a Python notebook environment, a function imported from
@loaders.gl/core
is not available, and throws an error when calling requestWithParameters:There's some nuance in how the Python packages load dependencies from CDNs, which could benefit from a closer look, but in the meantime ... the function is very short, and maybe importing it from
@loaders.gl/core
is unnecessary. To resolve the bug, I've copiedisObject
andisPureObject
into the CARTO module, both are one-liners.Publishing a patch release of
@deck.gl/carto
will be enough to fix the bug — pydeck-carto does not require an update.Background
Change List
isObject
andisPureObject
from@loaders.gl/core