feat(widgets): Remove onViewportChange
Update Guard for Widgets
#9303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9278
Background
This PR addresses an issue in
onViewportChange
where an optimization can prevent widgets from receiving a viewport. The issue was first noticed in the react environment becauselastViewports
is set before all widgets are fully mounted, leaving some widgets in an uninitialized state.To resolve this, the guard logic in
onViewportChange
has been removed and the responsibility for handling performance concerns, such as avoiding excessive calls toonViewportChange
, is pushed to individual widgets.Change List
onViewportChange
that previously comparedlastViewports
.Alternative Considered
Widget Manager Updates Viewports: Fully delegate viewport updates to the widget manager by comparing state directly on the widget instead of relying on
lastViewports
.lastViewports
would still remain, as it is used by the manager for other purposes.This approach was ultimately not chosen to avoid adding required elements to the
Widget
interface.