Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(widgets) Widgets should be reactive to prop changes #9315

Merged
merged 4 commits into from
Dec 22, 2024

Conversation

chrisgervang
Copy link
Collaborator

For #7457

Background

Found non-reactive props while working on #9314. Widgets should be able to change their placement or view as the user changes these props. It's just up to the widgets to actually implement how this is done..

Change List

  • Internal changes to widgets to update members as props change.

@coveralls
Copy link

coveralls commented Dec 21, 2024

Coverage Status

coverage: 91.703%. remained the same
when pulling ea973f5 on chr/reactive-widgets
into 05f8c95 on master.

@chrisgervang chrisgervang merged commit 17ab465 into master Dec 22, 2024
2 checks passed
@chrisgervang chrisgervang deleted the chr/reactive-widgets branch December 22, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants