Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(copc): New module for COPC format #3030

Merged
merged 1 commit into from
Jun 20, 2024
Merged

feat(copc): New module for COPC format #3030

merged 1 commit into from
Jun 20, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Jun 19, 2024

No description provided.

@ibgreen ibgreen mentioned this pull request Jun 19, 2024
9 tasks
@ibgreen ibgreen marked this pull request as ready for review June 19, 2024 12:14
@ibgreen ibgreen merged commit 4f06aa7 into master Jun 20, 2024
1 check passed
@ibgreen ibgreen deleted the ib/copc branch June 20, 2024 13:13
@hobu
Copy link

hobu commented Nov 21, 2024

Curious about the reasons for copc.js forking. I'm sure @connormanning would have merged patches, and we are still actively improving it.

@ibgreen
Copy link
Collaborator Author

ibgreen commented Nov 21, 2024

@hobu @connormanning
I am not sure I can set aside the time to prepare PRs but I might be able to write up some feedback.

  • I seem to remember that there was a hard node.js dependency that was a complete deal breaker as it got picked up by certain bundlers on the browser.
  • Also was hard to access the internal COPC pieces that I need to integrate with loaders.gl infrastructure (make a loader that loads from URL, load from Blob etc using @loaders.gl/core). Like other libraries I seem to recall that it offers those features at the top level.

@connormanning
Copy link
Collaborator

Thanks for the notes - I will take a look through what you've done here and see if there's anything that looks straightforward to update in copc based on how you've implemented things.

@ibgreen
Copy link
Collaborator Author

ibgreen commented Nov 22, 2024

I am starting to collect notes in #2911, let's see if that helps.

FWIW, I would be willing to collaborate and make some PRs if we can find a way to connect and discuss. I don't want to just make random offline PRs in a fork hoping the intent is understood and that they eventually land...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants