Skip to content

Commit

Permalink
Unpin setuptools (kedro-org#712)
Browse files Browse the repository at this point in the history
Pinning setuptools's upper bound will cause conflict with dependencies in user's projects that don't pin it. For example, consider a user's project which has the following in their requirements.txt, which is very common:

```
ipython
kedro
```

Ipython also specifies setuptools as a dependency without an upper bound and it is always listed before Kedro in alphabetical order. When pip tries to resolve dependency, at the moment, since it only performs conflicts resolution in a "first-encounter wins" manner, it will register latest setuptools from IPython as a dependency, which will conflict with Kedro's pinned version. If user moves IPython below Kedro, it should work correctly again.

So to be absolutely certain, this commit unpins setuptools.
  • Loading branch information
limdauto authored Jul 15, 2020
1 parent 0803af2 commit 6d1b5be
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ clean:
pre-commit clean || true

install-pip-setuptools:
python -m pip install -U "pip>=20.0, <21.0" "setuptools>=38.0, <47.0" wheel
python -m pip install -U "pip>=20.0" "setuptools>=38.0" wheel

legal:
python tools/license_and_headers.py
Expand Down
4 changes: 2 additions & 2 deletions features/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@ def _setup_base_venv(context):
"pip",
"install",
"-U",
"pip>=20.0, <21.0",
"setuptools>=38.0, <47.0",
"pip>=20.0",
"setuptools>=38.0",
"wheel",
],
env=context.env,
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ pip-tools~=5.0
pluggy~=0.13.0
python-json-logger~=0.1.9
PyYAML>=4.2, <6.0
setuptools>=38.0, <47.0
setuptools>=38.0
toposort~=1.5 # Needs to be at least 1.5 to be able to raise CircularDependencyError

0 comments on commit 6d1b5be

Please sign in to comment.