Put back work-around for talents of the characters on the china server #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-apply this work-around. Without it, getting informations for a character on a China server crash, as China has not switched to the new API at this time.
Blizzard has finally added lfr stats. :) The wow api seems to return 0 for some boss ids. To prevent problems, we replace the id with the boss name in these cases.
The blizzard API returns sometime {} instead of error when fetching one no more
existing character.
Add character role (DPS, TANK or HEALING)
Add information about item random enchant
Artifact is not existing in WoW, but...
The "new" dev website is https://dev.battle.net/. Using it mean a change in the base url, mainly https://%(region)s.api.battle.net/%(game)s%(path)s?apikey=%(apikey)s&%(params)s instead of https://%(region)s.battle.net/api/%(game)s%(path)s?%(params)s One of the important change is that every application who want to use it must have a api key.
So, we need to compare with lowercase().
We can now start tests with:
python -m unittest tests
assuming the BNET_API_KEY is defined.
Minor changes (some changes in a guild used for the tests).
So, we can use it for getting real item level for relics.
- no more PVP/PVE realms, - remove obsolete info on items, - add azerite infos.
No more supporting the "old" *.api.battle.net API, but now support the new upcoming *.api.blizzard.com API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this patch was remove with your last commit.
I have also add a test case for it.
Thanks in advance for applying it again.
Have a nice day.