Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previousSelection returned entire object vs ids #1734

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Mar 25, 2022

  1. previous selection returned entire object vs ids

    Previous selection was returning the entire node and edge objects rather than just an array of ids. This fixes it. I only tested it via modifying the vis-network.min.js file directly, but have translated it back to this format. Please check and improve as necessary. 
    `
      value: function (g, A) {
                        var t = !1,
                            e = this._selectionAccumulator.commit(),
                            C = {},
                            nodes = [], 
                            edges = [];
                        
                        for (let i = 0; i < e.nodes.previous.length; i++ ){
                            nodes.push(e.nodes.previous[i].id);
                        };
                        for (let i = 0; i < e.edges.previous.length; i++ ){
                            edges.push(e.edges.previous[i].id);
                        };
                        
                        C = {
                            nodes: nodes,
                            edges: edges
                        };
    `
    nickchomey authored Mar 25, 2022
    Configuration menu
    Copy the full SHA
    5cf44a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. Configuration menu
    Copy the full SHA
    b7839ba View commit details
    Browse the repository at this point in the history
  2. .

    nickchomey authored Mar 29, 2022
    Configuration menu
    Copy the full SHA
    d527382 View commit details
    Browse the repository at this point in the history