Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Mutable memory mapping #12

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[WIP] Mutable memory mapping #12

wants to merge 12 commits into from

Conversation

evetion
Copy link
Collaborator

@evetion evetion commented Jan 7, 2018

On top of #10

@evetion evetion requested a review from visr January 7, 2018 10:41
@codecov-io
Copy link

codecov-io commented Jan 7, 2018

Codecov Report

Merging #12 into master will increase coverage by 0.3%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #12     +/-   ##
=========================================
+ Coverage   62.62%   62.93%   +0.3%     
=========================================
  Files           8        8             
  Lines         396      402      +6     
=========================================
+ Hits          248      253      +5     
- Misses        148      149      +1
Impacted Files Coverage Δ
src/LasIO.jl 100% <ø> (ø) ⬆️
src/fileio.jl 45.45% <75%> (-0.7%) ⬇️
src/point.jl 67.27% <77.77%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c35f4c...4939d02. Read the comment docs.

@visr
Copy link
Owner

visr commented Jan 15, 2019

What shall we do with this? It looks useful to be able to replace points in a memory mapped PointVector.

As far as I see no need to also make LasPoint mutable, other than convenience. I'm worried about performance if we do that. We can always include some convenience functions for updating the classifications for instance. Also packages like https://github.com/jw3126/Setfield.jl make "modifying" immutables less of a hassle.

@visr visr removed their request for review October 18, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants