Idea for orientation change support #9

[abdallahm]

This is an idea of supporting the orientation change, however it depends on another package for detecting the orientation change event, like react-native-orientation.

Please review the changes and let me know if you have any questions or concerns.

[abdallahm]

i think the checks failed because i had to insert the sheet source into the styles object to be able to retrieve the original source and reprocess it again.

[coveralls]

Coverage decreased (-3.003%) to 96.717% when pulling 1f49a26 on abdallahm:master into ccea7a3 on vitalets:master.

[coveralls]

Coverage decreased (-0.5%) to 99.242% when pulling 83a7f0c on abdallahm:master into ccea7a3 on vitalets:master.

[vitalets]

Hi @abdallahm

Could you make some effort in direction when we wrap the whole app in our <AppContainer> component and listen it's onLayout event to detect orientation change?
In that case we avoid additional orientation module.

[coveralls]

Coverage increased (+0.03%) to 99.746% when pulling 32cd544 on abdallahm:master into ccea7a3 on vitalets:master.

[abdallahm]

Hi @vitalets

Done, please check.

[vitalets]

I've pushed my drafts on this feature to separate branch orientation-support, lets move our work there.

I suggest creating layout module that will do all job for processing layout changes (not in utils as in your pr)
Here it is in more or less ready state: https://github.com/vitalets/react-native-extended-stylesheet/blob/orientation-support/src/layout.js

Also I suggest to provide <AppContainer> component. Those developers who want to listen orientation change, should just wrap application into it.

AppContainer itself: https://github.com/vitalets/react-native-extended-stylesheet/blob/orientation-support/src/components/app-container.js

Example of wrapping app:
https://github.com/vitalets/react-native-extended-stylesheet/blob/orientation-support/examples/orientation-change/app.js

The problem is to automatically update react components after orientation change.
For that my thought was to register each component in tracker that will push updates after orientation change:
https://github.com/vitalets/react-native-extended-stylesheet/blob/orientation-support/src/components/tracker.js
This approach was not finally ready. So it woulb be great if play with stuff in orientation-change branch and make PR if got it working..

[vdhpieter]

Is there any progress on this? It would be very awesome!

[vitalets]

hi @vdhpieter

I am currently a bit out of mobile unfortunately..

[Antoine-C]

Hi !

Any update on this feature?

[vitalets]

Hi @Antoine-C

unfortunately not :(

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[neiker]

Note this can be a false positive on iPad when using split view after this bug was fixed:
facebook/react-native#16152