make HttpError valid response type #1508
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DRAFT]
Initial pass at #1507 - just to show it is possible, and rather easy
The main concern I can think of if the disconnect between an exception and the response from the exception (which is done by the exception handler). I think this could be improved by making the HttpException class generate the Response in a method - either by making it a pydnatic model (this might be messy when combined with exception) or continuing with my implementation to use the Schema as a TypeVar (similar to pydantic Generic)