Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing tool_proxy_guid assignment on deployment_request object. #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pfgray
Copy link

@pfgray pfgray commented Nov 16, 2015

Hiya,

Attempts to call

Lti2Tc::ToolRegistration.register_tool

with a valid deployment_request

are met with the error:

undefined method `tool_proxy_guid=' for #<Lti2Tc::DeploymentRequest:0x007ff216809e58>

/apps/LTI2-Reference/lti2_tc/app/models/lti2_tc/tool_registration.rb:27:in `register_tool'
app/admin/register_new_tool.rb:26:in `block (2 levels) in <top (required)>'
/apps/tmp/vendor/bundle/ruby/2.1.0/bundler/gems/active_admin-e3a7354c0196/lib/active_admin/views/pages/page.rb:8:in `instance_exec'
...

I believe this assignment (er method call? new to ruby...) was added in error, as tool_proxy_guid is not an attribute on Lti2Tc::DeploymentRequest instances, and the tool_proxy_guid is passed in later:

html_body = deployment_request.create_lti_message( tc_deployment_url, user.id, tool_proxy_guid )

Not exactly sure if this is correct, since this is literally the first ruby code I've written, but it solves the issue I've been having trying to run the LTI2 consumer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant