Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed csrf failures #374

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed csrf failures #374

wants to merge 4 commits into from

Conversation

pipakin
Copy link

@pipakin pipakin commented Nov 18, 2016

Fixed login failures, they were due to missing csrf tokens. This probably warrants a bit of a rewrite of this layer, as I had to do some hacky things (not a python dev) to get the tokens to correctly output.

@pipakin pipakin mentioned this pull request Nov 18, 2016
@ghost
Copy link

ghost commented Nov 22, 2016

I testes this one and it works for me. Please merge.

Copy link

@beyondpie beyondpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It indeed helps me make geeknote work.

@pravsripad
Copy link

+1 Solved my broken setup as well.

@faraway1nspace
Copy link

This solved my problem and got geeknote login working :)

@ghost
Copy link

ghost commented Jan 7, 2017

Solves login issue like a charm ;-)

@pipakin pipakin mentioned this pull request Jan 10, 2017
@DataThinkMonkey
Copy link

Cheers. Solved.

@RG9
Copy link

RG9 commented Jan 13, 2017

+1 Thank you :)

@1xPdd
Copy link

1xPdd commented Jan 20, 2017

Sorry for the newb question but how does one use this fix? I'd really like to have geeknote working again.

@pravsripad
Copy link

@1xPdd Easiest is to simply clone geeknote from git clone git://github.com/pipakin/geeknote.git

@1xPdd
Copy link

1xPdd commented Jan 20, 2017

@pravsripad OK. Thanks!

@dustinkeib dustinkeib mentioned this pull request Jan 21, 2017
@logie17
Copy link

logie17 commented May 1, 2017

👍

@hardaker
Copy link

For those that are looking for the easy patch to your local pull:

# git remote add pipakin git://github.com/pipakin/geeknote.git

# git fetch pipakin
remote: Counting objects: 13, done.
remote: Total 13 (delta 4), reused 4 (delta 4), pack-reused 9
Unpacking objects: 100% (13/13), done.
From git://github.com/pipakin/geeknote
 * [new branch]      dev        -> pipakin/dev
 * [new branch]      master     -> pipakin/master
 * [new branch]      stepler    -> pipakin/stepler
 * [new branch]      varche1    -> pipakin/varche1
 * [new branch]      vitaliy    -> pipakin/vitaliy

# git cherry-pick 89c3c3f
[master ec9be9c] Fixed csrf failures
 Author: Philip Kin <[email protected]>
 Date: Fri Nov 18 17:04:50 2016 -0600
 1 file changed, 39 insertions(+), 4 deletions(-)

@ankitdbst
Copy link

+1. Thanks for the fix.
If you have already installed the repo, then from the repo of geeknote run the following commands to patch the above fix:

git pull origin pull/374/head
python setup.py install

@developma
Copy link

It works out. Thanks!!

@chrisfleming
Copy link

Perfect this worked for me. The only wrinkle was missing lxml modules, which I installed manually.

@WyldeCat
Copy link

Thanks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.