feat: add legacy inconsistent cjs interop #464
Merged
+34
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
sapphi-red
force-pushed
the
feat/add-legacy-inconsistent-cjs-interop
branch
from
3f05f0f to
b5e5a67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
legacy.inconsistentCjsInterop: trueoption to opt-in to the previous inconsistent behavior.In normal Vite, Vite had inconsistent CJS interop behavior. This was due to the different behavior of esbuild and the Rollup commonjs plugin. rolldown-vite uses Rolldown for both the dependency optimization in dev and the production build, which aligns the behavior to esbuild.
requires rolldown/rolldown#6687
refs #444
fixes #457
fixes #458