-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: createViteRuntime should be imported from vite #16067
Conversation
Run & review this pull request in StackBlitz Codeflow. |
docs/guide/ssr.md
Outdated
@@ -134,7 +136,7 @@ app.use('*', async (req, res, next) => { | |||
// It fully supports HMR and works in a simillar way to ssrLoadModule | |||
// More advanced use case would be creating a runtime in a separate | |||
// thread or even a different machine using ViteRuntime class | |||
const runtime = await vite.createViteRuntime(server) | |||
const runtime = await createViteRuntime(server) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that we shouldn't be creating createViteRuntime
for every request I guess. @sheremet-va Does this work fine?
Maybe we should extract the ViteRuntime part and put a complete example in ::: details
block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a complete example will definitely help a lot!
By the way, this will be removed in 5.3 - #16089 |
Closing as we removed this section for now. Thanks for the PR 🙏 |
Description
Fix typo in Vite SSR documents.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).