Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea I had for #16471 (comment). Feel free to let me know too if this is a bad idea
What I'm thinking is that
build.entireApp
currently has a different meaning:build()
orcreateBuilder()
With this PR, I removed the
build.entireApp
option entirely and let frameworks manage them themselves.--app
, they should callcreateBuilder
or ensure thevite
CLI is called with--app
build()
(same as before, not changed)--app
, or frameworks can expose an option to pick between both.