Fix data race and execution ID comparison

Signed-off-by: Florent Poinsard <[email protected]>

go/server/api.go

@@ -595,7 +595,12 @@ func (s *Server) addExecutions(c *gin.Context) {
 		}
 	}
 
-	s.appendToQueue(newElements)
+	addToQueue := func() {
+		mtx.Lock()
+		defer mtx.Unlock()
+		s.appendToQueue(newElements)
+	}
+	addToQueue()
 
 	c.JSON(http.StatusCreated, "")
 }

go/server/cron.go

@@ -64,6 +64,19 @@ var (
 func (ei executionIdentifier) equalWithoutUUID(id executionIdentifier) bool {
 	ei.UUID = ""
 	id.UUID = ""
+
+	// If one has a profile and the other doesn't, it's not equal
+	if ei.Profile != nil && id.Profile == nil || ei.Profile == nil && id.Profile != nil {
+		return false
+	}
+	// If both have a profile, but they're different, it's not equal
+	if ei.Profile != nil && id.Profile != nil && *ei.Profile != *id.Profile {
+		return false
+	}
+	// Setting the profiles to nil so they don't mess up the equality comparison below
+	ei.Profile = nil
+	id.Profile = nil
+
 	return ei == id
 }