Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality of filtering of Status page data #527

Merged
merged 11 commits into from
May 20, 2024
Merged

Added functionality of filtering of Status page data #527

merged 11 commits into from
May 20, 2024

Conversation

Gmin2
Copy link
Contributor

@Gmin2 Gmin2 commented Apr 23, 2024

Screencast.from.23-04-24.04.24.25.PM.IST.webm

The local developement have been done by hardcoded data, as server(api-docker container) was not spinning up locally

@Gmin2 Gmin2 requested a review from frouioui as a code owner April 23, 2024 10:56
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am on Google Chrome and I am having issues reproducing the behavior you're showing on the video. The filtering does not work properly on my side.

@frouioui frouioui dismissed their stale review April 25, 2024 17:16

Requested changes have been applied.

@frouioui frouioui self-requested a review April 25, 2024 17:16
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to run the project as it was not building with data.json

@frouioui
Copy link
Member

I love the new design it looks great! Just one nit, we should remove a bit of padding to the dropdown so we can align them with the left hand side of the tables:
image

@frouioui frouioui self-requested a review April 26, 2024 22:51
@Gmin2
Copy link
Contributor Author

Gmin2 commented May 6, 2024

Doneeeee @frouioui

image

@frouioui
Copy link
Member

frouioui commented May 6, 2024

I am still seeing some gap depending on the size of the screen. Is there a way of "sticking" these components (the dropdown + execution queue + previous execution) in the same div and aligning everything.

Good alignement:
image

After increasing the size of the screen:
image

@Gmin2
Copy link
Contributor Author

Gmin2 commented May 10, 2024

Hey @frouioui i have alligned the select component in the center instead of it being at the start, it is looking nicer here

image

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for aligning the drop downs to the center, however, since the last commit the table containing all the execution has shrinked a bit and there is now a visible scroll bar to the right of the table. Can we let the table as wild as it was before?

image

@Gmin2
Copy link
Contributor Author

Gmin2 commented May 20, 2024

image
the scrollbar is there is every page, i think there is problem with the DisplayList.tsx, should i modify in this PR or create a new one as it will effect all the pages

cc @frouioui

@frouioui
Copy link
Member

Ah right I am seeing the same issue on the PR page. Yes, feel free to open a follow up PR.

@frouioui
Copy link
Member

That's really good work, it is a nice feature that will be really useful. Thank you! As soon as you resolve the merge conflict I will be able to merge this PR.

@Gmin2
Copy link
Contributor Author

Gmin2 commented May 20, 2024

Done @frouioui

@frouioui frouioui merged commit dcff8be into vitessio:main May 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants