feat(types): Added types in useApiCall hooks
#529
Conversation
There was a problem hiding this comment.
I think overall the changes proposed in this Pull Request look good to me, I left two nits. I see in the PR description you want to add type definition for the compare page, let's do this. Moreover, could you go over the FK and Daily pages? That way we will be using proper types in every page.
Only page left would be the query comparison page, but this can be left for later, the API for that page has to change a little bit too anyway.
Not approving this as you're planning on doing more work, but looks great!
|
After merging #538 there are some conflicts on this branch. |
My end exams semester are going on will be resolving it after the week |
No worries at all, take your time and good luck. |
|
Ready to review @frouioui |
|
@frouioui can we merge this soon, its types are very important to migrate other component |
Signed-off-by: Florent Poinsard <[email protected]>
Completed the migration to typescript for all the API calls in pages .